M1-TOP Page / UI #9
Conversation
| @@ -0,0 +1 @@ | |||
| 20.8.0 | |||
There was a problem hiding this comment.
I thought we need it so I added
There was a problem hiding this comment.
Nice, but different version ?
frontend/.github/workflows/lint.yml
Line 17 in 95cbd38
I'd say both have to be same version.
Probably 20.8.0 would be better, due to Next.js version 14's node version prerequisites.
There was a problem hiding this comment.
@Yo-mah-Ya
Thank you! I changed it
f7e13af
| import { InputSearch } from '@/components/input' | ||
|
|
||
| export const TripSearch = () => { | ||
| return <InputSearch /> |
There was a problem hiding this comment.
This component has meaning. I will add more to this component in next PR
app/page.tsx
Outdated
There was a problem hiding this comment.
I noticed that when the screen size is md (768px - 991px), the card component takes up 100% of the width, and it looks too big. It might look better if it were set to 70% width or something like that?
There was a problem hiding this comment.
Oh I did it on purpose! I thought it's better to make the width as 100% since the other components are width 100% and I wanted to arrange it in same line. I could do two columns for iPad instead but I just did one column as SP size. Maybe it's better?
There was a problem hiding this comment.
@SachiGoto
I changed to two columns! M1-Top_ui
Description
URL is http://localhost:3000/
Fixes # (issue)
Type of change
Screenshot
PC
Tablet
SP
