Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header-params): Add support for header parameter extraction #29

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

AlbRoehm
Copy link
Contributor

@AlbRoehm AlbRoehm commented Oct 9, 2024

Add functions and data classes for header parameter handling.
One missing piece is how to decide weather a header parameter is required. I did not have a good idea how to extract this without adding some kind of annotation.

@tabilzad
Copy link
Owner

tabilzad commented Oct 9, 2024

Thanks so much for the PR. Should be good to merge once the test is updated to cover all implementation scenarios. Let me know if you also wanna include parsing standard headers like with call.request.header(HttpHeaders.ContentLength). If not, we I can do it in a separate PR.

Replace full duplicates in Header & QueryVisitors
@AlbRoehm AlbRoehm requested a review from tabilzad October 10, 2024 19:17
@tabilzad tabilzad merged commit c6dd99b into tabilzad:master Oct 13, 2024
1 check passed
@AlbRoehm AlbRoehm deleted the add-header-parameter-extraction branch October 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants