-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to deploy models remotely #652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @jakeichikawasalesforce! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-25 21:44:20 UTC |
jakeichikawasalesforce
changed the title
Add capability to deploying models remotely
Add capability to deploy models remotely
Nov 22, 2024
dleskosky
approved these changes
Nov 22, 2024
jmoens
reviewed
Nov 25, 2024
jmoens
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote Deploy
This PR adds the capability to deploy models to a remote server by creating a client with
remote_server=true
. See this PR's docs/tabpy-tools.md for usage./evaluate
endpoint to run the script.If TABPY_EVALUATE_ENABLE is set to False in the config, this remote deployment will not work, which is the intended behavior (otherwise this would provide a hack where the user can upload arbitrary code and then execute it with the query endpoint).
Other Fixes:
time.sleep(interval)
to beginning of _wait_for_endpoint_deployment; this helps prevent a 500 error response when the model did indeed deploy.