fix: Fixing default values for size and stroke attributes

[andrey-hohlov]

Defining default values as it's done for React component.
Fixes #1067

Summary by CodeRabbit

• New Features

  • Introduced default values for the size and stroke properties in the icon component, ensuring consistent rendering and improved usability.

• Bug Fixes

  • Resolved potential rendering issues by providing default values, preventing undefined parameters.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
tabler-icons	✅ Ready (Inspect)	Visit Preview	Sep 26, 2024 11:45pm

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[andrey-hohlov]

We still need to have default size value as react package has

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[coderabbitai]

Walkthrough

The changes made to the createVueComponent function involve setting default values for the size and stroke properties in the IconProps object. This adjustment ensures that if these properties are not provided, they will default to 24 for size and 2 for stroke, enhancing the component's usability.

Changes

File	Change Summary
packages/icons-vue/src/createVueComponent.ts	Default values for size and stroke properties added to the createVueComponent function.

Assessment against linked issues

Objective	Addressed	Explanation
Default stroke-width should be set if not provided (#1067)	✅

🐇 "In a world of icons, bright and bold,
With size and stroke, a story told.
No more undefined, just values true,
A hop of joy for me and you!
Let’s dance in colors, let’s play all day,
With every stroke, we’ll find our way!" 🌈

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cabd37d and 9cac89d.

Files selected for processing (1)

• packages/icons-vue/src/createVueComponent.ts (1 hunks)

Additional comments not posted (1)

packages/icons-vue/src/createVueComponent.ts (1)

12-12: LGTM! The changes align with the PR objective.

The code changes are approved for the following reasons:

• The addition of default values for the size and stroke parameters aligns with the PR objective of defining default values for these attributes.
• The default values ensure that the component behaves consistently even when these attributes are not provided, enhancing its usability.
• The changes do not introduce any syntax errors or logical issues.
• The changes are limited to the function signature and do not affect the rest of the function body.