Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Opcodes and Errors classes in generated Typescript code #1100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Opcodes and Errors classes in generated Typescript code #1100

wants to merge 4 commits into from
+52 −12

Conversation

Shvandre
Copy link
Contributor

@Shvandre Shvandre commented Nov 28, 2024 •
edited
Loading

Issue

Closes #1033 .

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in docs/ and made the build locally
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Shvandre Shvandre requested a review from a team as a code owner November 28, 2024 09:02
@Shvandre Shvandre self-assigned this Nov 28, 2024
@anton-trunov anton-trunov changed the title Added Opcodes and Errors classes in generated Typescript code. Add Opcodes and Errors classes in generated Typescript code Nov 28, 2024
@anton-trunov anton-trunov added the scope: ts-wrappers TypeScript wrappers for Sandbox tests label Nov 28, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Nov 28, 2024
anton-trunov
anton-trunov requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's either

  • add tests with the new functionality, or
  • simplify the existing tests using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

@verytactical verytactical Awaiting requested review from verytactical

Requested changes must be addressed to merge this pull request.

Assignees

@anton-trunov anton-trunov

Labels
scope: ts-wrappers TypeScript wrappers for Sandbox tests
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Enum "Opcodes" and "Errors" are possibly missing in generated .ts file
2 participants
@Shvandre @anton-trunov