-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: slice
, rawSlice
, ascii
and crc32
built-in functions
#787
Conversation
slice
, rawSlice
, ascii
and crc32
built-in functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What does
slice
andrawSlice
correspond to in FunC string suffixes? - Let's add some negative tests, for instance,
ascii("000000000000000000000000000000000")
is supposed to fail due to overflow (33 zeros * 8 = 264 bits)`
cspell |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a negative test with rawSlice(s)
where s
won't fit into a cell
…teral type from FunC
dfb1fa8
to
70946f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Issue
Closes #444.
slice()
isn't actually an equivalent of any string literals, but just a more efficient way to define slice constants from BOC, similarly tocell()
rawSlice("abcd")
is an equivalent of"abcd"s
in FunCascii("hello world")
is an equivalent of"hello world"u
in FunCcrc32("hello world")
is an equivalent of"hello world"c
in FunCChecklist