feat: named table data as DataRef type
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted table metadata retrieval into a separate function `get_table_meta` for code reuse and clarity. This change simplifies the `table_by_name` function and introduces a new `table_by_name_ref` function that also leverages the shared `get_table_meta` functionality.
tafia
approved these changes
Sep 16, 2024
src/lib.rs
Outdated
| @@ -932,13 +932,13 @@ impl<'a, T: 'a + CellType> DoubleEndedIterator for Rows<'a, T> { | |||
| impl<'a, T: 'a + CellType> ExactSizeIterator for Rows<'a, T> {} | |||
|
|
|||
| /// Struct with the key elements of a table | |||
| pub struct Table<T> { | |||
| pub struct Table<T: CellType> { | |||
There was a problem hiding this comment.
I think it is better to refrain from adding constraints on the structs, the impl are enough, more generic and more future proof.
src/lib.rs
Outdated
| pub(crate) name: String, | ||
| pub(crate) sheet_name: String, | ||
| pub(crate) columns: Vec<String>, | ||
| pub(crate) data: Range<T>, | ||
| } | ||
| impl<T> Table<T> { | ||
| impl<T: CellType> Table<T> { |
There was a problem hiding this comment.
Same here, it is unnecessary I think.
|
@tafia Is there anything else you need me to change in this PR? |
|
Sorry for the late answer lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some work I was performing on a MR for
fastexcel(ToucanToco/fastexcel#282) I noticed no method for retrievingTables withDataRefas inner type was not possible. This MR should hopefully resolve this issue.I also implemented
From<Table<T>>forRange<T>to prevent large clone operations, which I ran into in one method in particular insidefastexcel.Finally I resolved a small
clippywarning mentioning thatstd::u32::MAXis deprecated.Eager to receive your feedback :)