task/WG-139: add uuid for guest users #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store in local storage and add to requests headers
taoteg
reviewed
Nov 3, 2023
There was a problem hiding this comment.
This appears to be a nearly redundant PR to this one: TACC-Cloud/hazmapper#166
Not sure what order these need to be applied.
Could these be combined into a single PR?
@taoteg , yeah 100% a line for line copy of the changes in hazmapper. they are both client code so take the same approach. we could make a shared library for the two to try to limit the duplication of code but would rather ignore that for now as Hazmapper is moving to React and Taggit (for the time being) is staying in angular. |
taoteg
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add uuid for guest users:
Related Jira tickets:
Testing Steps:
TACC-Cloud/geoapi#155 has testing steps but they don't apply here as we don't have a public map/gallery view yet for taggit.
So this PR really just added guest ID which can be used whenever we do implement a public/gallery view for taggit