Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use cargo insta to run tests #3220

Merged
merged 7 commits into from
Dec 11, 2024
Merged

ci: use cargo insta to run tests #3220

merged 7 commits into from
Dec 11, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Dec 10, 2024

Summary:

  • use cargo insta runner instead of cargo llvm when the coverage is not needed. This allows to fail when unreferenced snapshots found and this forces the explicit removal of snapshots in the prs that removes the related tests
  • drop jit_test workflow
  • force update snapshots to the new insta format. It's to minimize noise in the future prs that updates snapshots

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (0f3721b) to head (a3a63b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3220   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         281      281           
  Lines       28443    28443           
=======================================
  Hits        24683    24683           
  Misses       3760     3760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meskill meskill force-pushed the ci/insta-snapshots branch 4 times, most recently from d914172 to c0a2872 Compare December 10, 2024 21:41
@meskill meskill changed the title ci: use cargo insta for run tests ci: use cargo insta to run tests Dec 10, 2024
@meskill meskill marked this pull request as ready for review December 10, 2024 22:26
@tusharmath tusharmath merged commit 0b05b83 into main Dec 11, 2024
38 checks passed
@tusharmath tusharmath deleted the ci/insta-snapshots branch December 11, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants