android cmake: ignore symlinks to match toolchain machine name #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the NDK contains more than one file suffixed with -gcc, it will
fail to detect the toolchain machine name, as the logic expects only
one result.
Just ignore the any symlink we may have when listing the -gcc suffixed
files.:
ls -l /opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/*-gcc
/opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androideabi-gcc
/opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-gcc -> arm-linux-androideabi-gcc
|
This would be a very welcome addition, and would save people some time. Thanks anyway @aleksander0m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NDK contains more than one file suffixed with -gcc, it will
fail to detect the toolchain machine name, as the logic expects only
one result.
Just ignore the any symlink we may have when listing the -gcc suffixed
files.:
ls -l /opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/*-gcc
/opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androideabi-gcc
/opt/android/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-gcc -> arm-linux-androideabi-gcc