Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add find_host_file macro #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add find_host_file macro #34

wants to merge 1 commit into from

Conversation

rlei
Copy link

@rlei rlei commented Jan 12, 2015

This pull request adds a find_host_file macro to cmake find_file, just like find_host_package to the original find_package.

I personally experienced the issue with find_file when building https://github.com/rlei/fastd-android using android-cmake. One of its cmake files has the following

    find_file(DOXYFILE_IN "Doxyfile.in"
            PATHS "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_ROOT}/Modules/"
            NO_DEFAULT_PATH
            DOC "Path to the doxygen configuration template file")

which can't find the file Doxyfile.in in the CMAKE_CURRENT_SOURCE_DIR folder. With the new macro it works fine.

And thanks for your nice work on android-cmake :)

@taka-no-me
Copy link
Owner

Capturing CMAKE_FIND_ROOT_PATH is not a good way to go. It's better to implement find_host_path similarly to find_host_package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants