Fix memory leak in SWIG-generated proxy classes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled latest versions of config.guess and config.sub from their upstream locations (as documented in those files). This is necessary for the configure process to correctly recognize GNU/Linux on AAarch64, for example.
Add the %newobject SWIG declaration to the factory methods createLattice() and createTagger() of the class MeCab::Model. This makes it clear that the caller takes on ownership of the pointer returned by these factory methods. Without this declaration, calls in e.g. Java to Model.createLattice() and Model.createTagger() will leak memory, as the generatedd Java Lattice and Tagger proxy classes do not know that they have ownership of the underlying C++ pointers. As a result, instances of the proxy classes fail to delete the underlying C++ objects, leading to native (off-JVM-heap) memory leaks that are difficult to debug.
Update of auto-generated code only; no manual changes. Reran "make" in directory mecab/swig, using current SWIG version 4.0.2.
|
The crucial commit which fixes the memory leak is now d8678ef after today's force-push to my feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit 75fc31b for details.