Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tokenizer builder abstraction #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikob
Copy link

@mikob mikob commented Dec 18, 2018

The TokenizerBuilder didn't do anything significant, so I removed that layer of abstraction to simplify things. I also renamed the builder to be loader, and the dictionary builder to be builder. This is at least more consistent, and I think easier to understand.

I realize this is a bit forward, sorry for not asking permission first, but still hoping it makes sense/you accept 😺

…er. Made loader/builder terminology more consistent.
@mikob mikob force-pushed the removed-tokenizer-builder-abstraction branch from 98d1c30 to 09913ec Compare December 18, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant