add a test harness #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanco/database.py:15: ResourceWarning: unclosed file
tangentstorm
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks! I was just thinking of adding a test suite when I saw this. :)
Quart is all async so I'm not sure unittest will be enough for testing the server, but this is a good start for testing the driver and runner.
I didn't know about pathlib. Cool.
I think you might have cut a little too much out of the .gitignore file ( pycharm is always changing stuff under .idea) but I agree it's nicer this way and I can just explicitly re-ignore anything that gets in the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.