Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump circomlibjs from 0.0.8 to 0.1.7 #1729

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps circomlibjs from 0.0.8 to 0.1.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [circomlibjs](https://github.com/iden3/circomlibjs) from 0.0.8 to 0.1.7.
- [Commits](iden3/circomlibjs@v0.0.8...v0.1.7)

---
updated-dependencies:
- dependency-name: circomlibjs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit 192759b
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/651f048831fc4b00082f1049
😎 Deploy Preview https://deploy-preview-1729--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { poseidon } from 'circomlibjs';

const hash = poseidon([chainId, amount, keypair.getPubKey(), blinding]);

We have utilized the poseidon function from the circomlibjs library to compute the commitment. However, in this updated version, the library no longer exposes that function. Consequently, an alternative method must be determined.

@drewstone
Copy link
Contributor

drewstone commented Oct 4, 2023

It's the same method basically @AtelyPham but afaik it is now an async function. So there should be a PR that ensures the outputs are the same from these versions and then updates to the async loader.

https://github.com/iden3/circomlibjs/blob/main/test/poseidon.js

@AtelyPham
Copy link
Member

AtelyPham commented Oct 4, 2023

After conducting an investigation, it was discovered that the new API returns a byte array, not a hash string as the previous API did. Further investigation will be carried out tomorrow.

Update: I attempted to use u8aToHex from @webb-tools/utils for testing, but the hashes differed. I believe it may be necessary to compare the implementations of both the old and new APIs to understand the differences.

@AtelyPham
Copy link
Member

Found the solution iden3/circomlibjs#13 (comment).

@AtelyPham AtelyPham self-requested a review October 5, 2023 18:47
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 192759bcf621d425e86ad566a89ce1f1ce983ff5
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/651f07010e8b610092affc31
😎 Deploy Preview https://651f07010e8b610092affc31--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@AtelyPham AtelyPham merged commit 6910088 into develop Oct 5, 2023
10 checks passed
@AtelyPham AtelyPham deleted the dependabot/npm_and_yarn/circomlibjs-0.1.7 branch October 5, 2023 19:21
@AtelyPham AtelyPham self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

2 participants