Adding Support For Multiple Note Accounts #1731
Conversation
…hods on webb provider
…o get vanchor instance
✅ Deploy Preview for hubble-stats ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham
To edit notification comments on pull requests, go to your Netlify site settings. |
|
✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham
To edit notification comments on pull requests, go to your Netlify site settings. |
| useEffect(() => { | ||
| let isSubscribed = true; | ||
|
|
||
| async function getStorageSize() { |
There was a problem hiding this comment.
We can use try/catch block here and also show an alert when the error is caught.
| // Disconnect function | ||
| // TODO: The disconnect function does not work properly | ||
| const handleDisconnect = useCallback(async () => { | ||
| if (currentManagedWallet && currentManagedWallet.canEndSession) { |
There was a problem hiding this comment.
Consider implementing try/catch blocks within this and subsequent asynchronous functions to enhance error handling. Additionally, utilizing alerts to display messages in the UI can improve user experience by providing informative feedback.
|
✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham
To edit notification comments on pull requests, go to your Netlify site settings. |
|
All requested changes have been addressed. I am going to merge this PR. |
Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an
xin the boxes that apply.apps/bridge-dappapps/hubble-statsapps/stats-dappapps/webbsiteapps/faucetapps/tangle-websitelibs/webb-ui-componentsReference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).
Screen Recording
If possible provide a screen recording of proposed change.
Switching note account when switching account from a third-party wallet
CleanShot.2023-10-03.at.04.51.10.mp4
The encrypted notes are updated based on the active note account
CleanShot.2023-10-03.at.04.58.59.mp4
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components.