-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tangle-dapp): Implement stake & unstake liquifier functionality for EVM-based liquid staking #2500
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the introduction of Liquifie, it might be better to call them LsProtocolId
unless we will map these protocols to chains and use Ethereum chain ID as a common parameter for staking protocols on Ethereum (Chainlink, Graph, Livepeer, etc.)
…nd `useContractRead`
Nearly ready to submit for review here. Just need to cleanup logic and errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍!
Ok gotcha so where it says Chainlink I would instead show the chain (Ethereum Mainnet) and then where it says LINK it would be the token on that chain? @drewstone |
Correct @yurixander. I think that slot is best for chain selection so its clear when you're bridging from one chain to another. Therefore, it can be clear if you're liquid staking and remaining on Ethereum vs bridging to Tangle. |
Makes sense and I agree. I'll implement that in my other PR. |
Summary of changes
Provide a detailed description of proposed changes.
(1/2)
), since the liquid staking process for EVM-based chains is composed of two steps (approve ERC20 for spending, then call liquifier contract).Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/tangle-dapp
apps/testnet-leaderboard
apps/faucet
apps/zk-explorer
libs/webb-ui-components
Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g.
Closes #233
).Screen Recording
If possible provide a screen recording of proposed change.
evm.liquid.stake.unstake.mp4
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components
.