Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Chain display name #2699

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(tangle-dapp): Chain display name #2699

merged 2 commits into from
Dec 16, 2024

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Fixes the chain name in the chain chip component within the transaction queue item.

Proposed area of change

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes

Screenshots

CleanShot 2024-12-15 at 08 15 16

CleanShot 2024-12-16 at 05 21 01

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 8e90e33
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67602bb8cefe2d00082dc1a6
😎 Deploy Preview https://deploy-preview-2699--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 8e90e33
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67602bb8118418000800cd16
😎 Deploy Preview https://deploy-preview-2699--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, LG 👍

Comment on lines 66 to 67
console.log('iconName', iconName);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the log here.

@devpavan04 devpavan04 merged commit 022ffc4 into develop Dec 16, 2024
15 checks passed
@devpavan04 devpavan04 deleted the PS/fix-chainchip branch December 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants