enforce vault input index of 0 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monlovesmango
changed the title
|
Thanks for taking a look! |
rot13maxi
approved these changes
Sep 26, 2024
src/vault/script.rs
Outdated
| @@ -26,6 +26,10 @@ pub(crate) fn vault_trigger_withdrawal() -> ScriptBuf { | |||
| // start with encoded leaf hash | |||
| .push_opcode(OP_CAT) // encoded leaf hash | |||
| .push_opcode(OP_CAT) // encoded leaf hash | |||
| .push_opcode(OP_SWAP) // bring input index to top of stack | |||
| .push_opcode(OP_DROP) // remove input index | |||
There was a problem hiding this comment.
Suggested change
| .push_opcode(OP_DROP) // remove input index | |
| // TODO: add an `index` field to the CommitmentSpec so that we can exclude it and remove the OP_SWAP and OP_DROP here | |
| .push_opcode(OP_DROP) // remove input index |
There was a problem hiding this comment.
just add this little TODO so in the future we can remove these two opcodes and save a little witness space :)
|
ok I think I completed the todo correctly. please verify. |
|
Looks good! thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update trigger and cancel scripts to force vault input to be first. otherwise if the fee paying transaction is the first input the vault can be drained to fees. (resolves #2 )
if you would like to test this fix you can use my
fee-drainbranch which creates a new action for draining via a trigger transaction and draining via a cancel transaction. (there is also a drain via complete transaction but it doesn't work and I don't think it can work).