feat: search commitment/kernels #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
force-pushed
the
fix-search-commitment
branch
from
bc9ef82
to
5359f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added search for kernels.
The search commitment was broken (wrong argument name).
Reworked the errors, all returns json when json is requested.
Motivation and Context
tari-explorer is a backend to the new tari explorer, so we need to keep this up-to-date.
How Has This Been Tested?
Manually.
What process can a PR reviewer use to test or verify this change?
Run this tari-explorer and test the search, also you can test the
&jsonin the url.Breaking Changes