feat: validator registration timelock #5978
Open
+252
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 107 suites 31m 37s ⏱️ For more details on these failures, see this check. Results for commit 2a66889. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 12m 10s ⏱️ For more details on these failures, see this check. Results for commit 2a66889. ♻️ This comment has been updated with latest results. |
SWvheerden
requested changes
Nov 23, 2023
SWvheerden
previously approved these changes
Nov 23, 2023
Cifko
force-pushed
the
vn-reg-lock
branch
2 times, most recently
from
fe780ed
to
f9861b1
Compare
Cifko
force-pushed
the
vn-reg-lock
branch
2 times, most recently
from
5082638
to
3338c9d
Compare
hansieodendaal
previously approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add VN registration timelock. It has to be set to at least for the validity period (base on current consensus).
Fix the money lock value, add a test value of 1T to it.
Motivation and Context
Fixes tari-project/tari-dan#831
How Has This Been Tested?
I did register a VN, and the I checked if it's timelocked in the wallet.
What process can a PR reviewer use to test or verify this change?
Register VN and see the timelock in the wallet.
Breaking Changes