Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TeyvatGuide #226

Merged
merged 1 commit into from
Oct 19, 2023
Merged

add TeyvatGuide #226

merged 1 commit into from
Oct 19, 2023

Conversation

BTMuli
Copy link
Contributor

@BTMuli BTMuli commented Oct 19, 2023

This is the link to the project: TeyvatGuide

  • I have read the contributing guidelines.
  • Use the following format: [Title](link) - Description.
  • If the project is closed source add the ![closed source] badge after the (link) but before the -.
  • If the project/article is non-free or paywalled add the ![paid] badge after the (link) but before the -.
  • Add entries alphabetically to the most appropriate category.
  • No unnecessary words like for Tauri, a Tauri plugin and Super-Fast.
  • Description does not start with A or An.
  • Description is under 24 words.
  • Description has no links or parenthesis.
  • Use backticks when mentioning package names.
  • Double-check spelling and grammar.
  • No trailing whitespace is added to the end of any file.
  • One suggestion per pull request.
  • I understand that my entry will be removed if it violates the guidelines.
  • I have signed my commits.

Apps

  • The app is original and not too simple.
  • The README is in English.
  • The app makes a reasonable effort to be fast, lightweight and secure.
  • If the app closed source, evidence of it being built with Tauri is included.

@FabianLars
Copy link
Member

Awesome, thanks! Do you think it's feasible to adapt your app so that you can don't need to allow the whole allowlist here? We're always a bit hesitant to merge apps that enable everything :)

@BTMuli
Copy link
Contributor Author

BTMuli commented Oct 19, 2023

We're always a bit hesitant to merge apps that enable everything :)

Ok..I had change it just now BTMuli/TeyvatGuide@8a3358a

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@FabianLars FabianLars merged commit 03b1e75 into tauri-apps:dev Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants