fix(sql): Fix QueryResult typings (#1928)

* fix(sql): Fix QueryResult typings closes #1893 * Create fix-sql-queryresult-type.md --------- Co-authored-by: Tillmann <[email protected]>
tauri-apps · Dec 2, 2024 · 3195646 · 3195646
1 parent 6f6a178
commit 3195646
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changes/fix-sql-queryresult-type.md b/.changes/fix-sql-queryresult-type.md
@@ -0,0 +1,5 @@
+---
+sql-js: patch
+---
+
+Fixed the QueryResult typing by marking `lastInsertId` as optional to reflect postgres-only changes made in the 2.0.0 release.
diff --git a/plugins/sql/guest-js/index.ts b/plugins/sql/guest-js/index.ts
@@ -10,12 +10,12 @@ export interface QueryResult {
   /**
    * The last inserted `id`.
    *
-   * This value is always `0` when using the Postgres driver. If the
+   * This value is not set for Postgres databases. If the
    * last inserted id is required on Postgres, the `select` function
    * must be used, with a `RETURNING` clause
    * (`INSERT INTO todos (title) VALUES ($1) RETURNING id`).
    */
-  lastInsertId: number
+  lastInsertId?: number
 }
 
 /**