Add global version_comparator #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through b467270There are 2 changes which include updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Oct 14, 2024
|
ok will fix it up this week |
amrbashir
requested changes
Nov 26, 2024
There was a problem hiding this comment.
@n1ght-hunter This LGTM, can you also add a change file in .changes directory?
n1ght-hunter
commented
Nov 27, 2024
amrbashir
reviewed
Dec 8, 2024
Co-authored-by: Amr Bashir <[email protected]>
amrbashir
approved these changes
Dec 9, 2024
amrbashir
requested changes
Dec 9, 2024
Co-authored-by: Amr Bashir <[email protected]>
amrbashir
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows you do set a
version_comparatorwhen building the plugin that will get applied to all subsequent calls.this does not change overriding if you call the builder manually but allows a way to alter version_comparator for js command calls