Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v2 http-plugin dangerous settings / disable ssl verification - issue #518 #2204

Open
wants to merge 11 commits into
base: v2
Choose a base branch
from

Conversation

RickeyWard
Copy link

@RickeyWard RickeyWard commented Dec 13, 2024

Since the HTTP plugin uses Reqwest under the hood, this adds the ability to set Reqwest client builder flags for danger_accept_invalid_certs and danger_accept_invalid_hostnames

Its on the roadmap as a proposal via #518

I'm uncertain how versioning works with the plugins-workspace monorepo, but I bumped the version of the http plugin.

I put this behind a feature flag for security reasons.

I attempted to follow existing conventions as closely as possible.

API changes allow for

await response = fetch("https://expired.badssl.com", 
                                          { danger: { acceptInvalidCerts: true, acceptInvalidHostnames: true } }
                             );

@RickeyWard RickeyWard requested a review from a team as a code owner December 13, 2024 18:18
@FabianLars
Copy link
Member

I'm uncertain how versioning works with the plugins-workspace monorepo, but I bumped the version of the http plugin.

No manual version bumps, only change files like https://github.com/tauri-apps/plugins-workspace/blob/10ce3537b460a1e72e8c9063f6ad910a24140664/.changes/persist-cookies.md

Copy link
Contributor

github-actions bot commented Dec 15, 2024

Package Changes Through 6c58554

There are 2 changes which include http with minor, http-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.11 2.0.12
api-example-js 2.0.8 2.0.9
http 2.2.0 2.3.0
http-js 2.2.0 2.3.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Contributor

@tweidinger tweidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants