Skip to content

Commit

Permalink
chore: cleanup issue and PR templates (#856)
Browse files Browse the repository at this point in the history
* chore: cleanup issue and PR templates

* Update bug_report.md

* Update feature_request.md

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
  • Loading branch information
amrbashir authored Dec 15, 2023
1 parent 68803e6 commit 50bba7f
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 35 deletions.
6 changes: 1 addition & 5 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ assignees: ''
A clear and concise description of what the bug is.

**Steps To Reproduce**
Steps to reproduce the behavior. It **must** use tao directly instead of tauri.
Steps to reproduce the behavior. It **must** use tao directly and not tauri.

**Expected behavior**
A clear and concise description of what you expected to happen.
Expand All @@ -23,10 +23,6 @@ If applicable, add screenshots to help explain your problem.
OS:
Rustc:

**Would you want to assign yourself to resolve this bug?**
- [ ] Yes
- [ ] No

**Additional context**
Add any other context about the problem here.

4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Would you want to assign yourself to implement this feature?**
- [ ] Yes
- [ ] No

**Additional context**
Add any other context or screenshots about the feature request here.

42 changes: 16 additions & 26 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,21 @@
<!--
Update "[ ]" to "[x]" to check a box
Before submitting a PR, please read https://github.com/tauri-apps/tauri/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
Please make sure to read the Pull Request Guidelines: https://github.com/tauri-apps/tauri/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

### What kind of change does this PR introduce?
<!-- Check at least one. If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers. -->

- [ ] Bugfix
- [ ] Feature
- [ ] Docs
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:
1. Give the PR a descriptive title.
### Does this PR introduce a breaking change?
<!-- If yes, please describe the impact and migration path for existing applications in an attached issue. -->
Examples of good title:
- fix(windows): fix race condition in event loop
- docs: update docstrings
- feat: add `Window::set_fullscreen`
- [ ] Yes
- [ ] No

### Checklist
- [ ] This PR will resolve #___
- [ ] A change file is added if any packages will require a version bump due to this PR per [the instructions in the readme](https://github.com/tauri-apps/tao/blob/dev/.changes/readme.md).
- [ ] I have added a convincing reason for adding this feature, if necessary
- [ ] It can be built on all targets and pass CI/CD.

### Other information
Examples of bad title:
- fix #7123
- update docs
- fix bugs
2. If there is a related issue, referenced in the PR text, e.g. closes #123.
3. If this change requires a new version, then add a change file in `.changes` directory with the appropriate bump, see https://github.com/tauri-apps/tao/blob/dev/.changes/readme.md
4. Ensure that all your commits are signed https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
5. Ensure `cargo test` passes.
6. Open as a draft PR if your work is still in progress.
-->

0 comments on commit 50bba7f

Please sign in to comment.