Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix appcrash on windows where darkmode is not supported #1022

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

Jnschrber
Copy link
Contributor

@Jnschrber Jnschrber commented Nov 27, 2024

The changes resolve this bug: tauri-apps/tauri#11674 where Tauri2 crashes immediately on Windows 10 LTSC 2016

closes tauri-apps/tauri#11674

@Jnschrber Jnschrber requested a review from a team as a code owner November 27, 2024 15:15
@FabianLars FabianLars requested a review from amrbashir November 27, 2024 15:42
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you also add a change file in .changes directory?

src/platform_impl/windows/dark_mode.rs Outdated Show resolved Hide resolved
Wrapping function in DarkModeSupported condition, added change file.
Copy link
Contributor

Package Changes Through 1f62329

There are 1 changes which include tao with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.30.7 0.31.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Jnschrber Jnschrber requested a review from amrbashir December 2, 2024 08:56
.changes/dark-mode.md Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit 2e6cf1a into tauri-apps:dev Dec 8, 2024
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Tauri2 crashes immediately on Windows 10 LTSC 2016
2 participants