Upgrade to TypeScript 5.6 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthemphill
commented
Oct 14, 2024
src/js/randomizer/history.ts
Outdated
Comment on lines
90
to
91
| setHistory: Dispatch<SetStateAction<History<Partial<T>>>>, | ||
| a: PureHistoryAction<Partial<T>>, |
There was a problem hiding this comment.
Could also remove the generic and make it
export function pureHistoryApply(
setHistory: SetHistory,
a: PureHistoryAction<Partial<ScriptState>>,
) { /* ... */ }
There was a problem hiding this comment.
Let's go with that. In principle having it generic is nice but there's only type of history in this project so let's just have it reflect that. I'd prefer having it be monomorphic than generic-but-not-as-generic-as-possible.
|
Thanks for looking into this, this fix really helped me understand what's going on. I checked and the actual issue isn't with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure the new version of TypeScript is pointing out that we're passing a
Partial<ScriptState>to a function that expects aScriptState. This PR just changes the function to expect aPartial<ScriptState>instead.