Skip to content

Commit

Permalink
fix #569: bump fastdatatable to escape cell contents; improve tooltip…
Browse files Browse the repository at this point in the history
… formatting and styling
  • Loading branch information
tconbeer committed Jul 10, 2024
1 parent b8099c9 commit 1862ce2
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ All notable changes to this project will be documented in this file.
### Changes

- Harlequin's Footer has been re-designed. In the footer, `CTRL+` key presses are now represented by a carat, `^`. For example, instead of `CTRL+Q Quit` the footer now reads `^q Quit`.
- The tooltip for overflowing data cells has been improved to better format the data contained in the cell.

### Bug Fixes

- Fixed a bug where the main panel would resize while the code editor was being mounted at app start-up.
- Fixed a bug that could cause a crash if data table cell contents contained a string that could be interpreted as bad Rich Markup ([#569](https://github.com/tconbeer/harlequin/issues/569) - thank you [@cmdkev](https://github.com/cmdkev)!)

## [1.22.2] - 2024-07-09

Expand Down
12 changes: 6 additions & 6 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ python = ">=3.8.1,<4.0.0"

# textual and component libraries
textual = "==0.72.0"
textual-fastdatatable = "==0.7.1"
textual-fastdatatable = "==0.8.0"
textual-textarea = "==0.14.0"

# click
Expand Down
2 changes: 2 additions & 0 deletions src/harlequin/app.tcss
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ Tooltip {
border: round $border-color-focus;
background: $background;
padding: 0 1;
max-height: 95vh;
max-width: 40%;
}

RunQueryBar Button {
Expand Down
2 changes: 1 addition & 1 deletion tests/functional_tests/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ async def test_select_1(
"select 1 where false",
"select 1 union all select 'hi'",
"select 'hi' union all select 1",
"""select '[/foo]' as "[/bar]" """.strip(),
],
)
async def test_queries_do_not_crash_all_adapters(
app_all_adapters: Harlequin,
query: str,
app_snapshot: Callable[..., Awaitable[bool]],
) -> None:
app = app_all_adapters
messages: list[Message] = []
Expand Down

0 comments on commit 1862ce2

Please sign in to comment.