Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update express-sms-autoresponder to Typescript #22

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Copy link
Member

@DRS90 DRS90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when I try to run the sms-autoresponder locally
Screenshot 2024-10-11 at 11 18 09

@lucasassisrosa
Copy link
Contributor Author

I get this error when I try to run the sms-autoresponder locally Screenshot 2024-10-11 at 11 18 09

thanks! probably some deps missing. Let me fix

Copy link

@BueTelnyx BueTelnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this to work!
Seems like a quick and easy demo, super powerful to sending text messages like this.
However one code change I suggest is have the port pull for the environment variables. Like const port = process.env.PORT || 5000

@lucasassisrosa
Copy link
Contributor Author

I get this error when I try to run the sms-autoresponder locally Screenshot 2024-10-11 at 11 18 09

fixed this by bumping telnyx package to 2.0.0-beta.3

https://github.com/team-telnyx/telnyx-node/releases/tag/v2.0.0-beta.3

@lucasassisrosa
Copy link
Contributor Author

lucasassisrosa commented Oct 15, 2024

Got this to work! Seems like a quick and easy demo, super powerful to sending text messages like this. However one code change I suggest is have the port pull for the environment variables. Like const port = process.env.PORT || 5000

thanks! I added this line to pull port from envs. Also changed default port to be 8000 since 5000 is often in use

@lucasassisrosa lucasassisrosa merged commit f3ae014 into master Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants