Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is/enhancement/pn-refactor + Custom Ringtone #330

Merged
merged 7 commits into from
Sep 24, 2023
Merged

Is/enhancement/pn-refactor + Custom Ringtone #330

merged 7 commits into from
Sep 24, 2023

Conversation

isaacakakpo1
Copy link
Contributor

@isaacakakpo1 isaacakakpo1 commented Sep 21, 2023 •
edited by jira bot
Loading

ENGDESK-25638

  • Refactored PN to be handled internally by SDK.
  • Custom Ringtone can be set by providing raw file or file uri

👴 👶 Behaviors

Before changes

  • Not Trivial to setup PN
  • No Support for Uri Ringtones

✋ Manual testing

  1. Call flow is working

@isaacakakpo1 isaacakakpo1 merged commit 010e11f into main Sep 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJSkorski RJSkorski RJSkorski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacakakpo1 @RJSkorski