Is/feature/handling multiple calls #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecated telnyxClient.call - Updated Client UI to Support multiple Calls
RJSkorski
reviewed
Apr 12, 2024
README.md
Outdated
| @@ -194,10 +194,28 @@ We can then use this method to create a listener that listens for an invitation | |||
|
|
|||
| When we receive a call we will receive an InviteResponse data class that contains the details we need to accept the call. We can then call the acceptCall method in TelnyxClient from our ViewModel: | |||
|
|
|||
| ### Handling Multiple Calls | |||
| The Telnyx WebRTC SDK allows for multiple calls to be handled at once. In order to handle multiple calls, you can use the callId to differentiate between calls. | |||
There was a problem hiding this comment.
In order to handle multiple calls => You can use the callId to differentiate the calls.
RJSkorski
reviewed
Apr 12, 2024
README.md
Outdated
| 4. EndCall `currentCall.endCall(callId: UUID)` | ||
|
|
||
|
|
||
|
|
||
| ## Adding push notifications | ||
| The Telnyx Android Client WebRTC SDK makes use of Firebase Cloud Messaging in order to deliver push notifications. If you would like to receive notifications when receiving calls on your Android mobile device you will have to enable Firebase Cloud Messaging within your application. |
There was a problem hiding this comment.
If you would like to receive notifications when receiving calls on your Android mobile device you will have to enable Firebase Cloud Messaging within your application. => If you want to receive notifications for incoming calls on your Android mobile device you have to enable Firebase Cloud Messaging within your application
RJSkorski
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRTC-29965- Ticket Description.
Handle Multiple Calls
Deperecated
telnyxClient.call.[option]👴 👶 Behaviors
Before changes
SDK only Supported one Global Call
After changes
SDK Supports Multiple Calls
✋ Manual testing
Inbound/OutBound Calls