Feature/main webrtc 2356 hold unhold for demo app #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver-Zimmerman
requested changes
Dec 5, 2024
| @@ -148,15 +149,29 @@ class MainViewModel @Inject constructor( | |||
| if (currentCall != null) { | |||
| telnyxClient?.endCall(currentCall?.callId!!) | |||
| } | |||
| //dev note - do we need it??? | |||
| currentCall?.endCall(currentCall?.callId!!) | |||
There was a problem hiding this comment.
Seems a bit strange to do it in both places? I believe they are referencing the same call? I believe we can remove it.
There was a problem hiding this comment.
Sure, I will change comment and push changes again
Oliver-Zimmerman
approved these changes
Dec 5, 2024
wojciechowskiradek
deleted the
feature/main_WEBRTC-2356_hold_unhold_for_demo_app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRTC-2356 - Implement Hold and Unhold for Android Demo App.
User is able to hold current call, when the other call is incoming. Number of holded calls is unlimited.