[feat] 마이페이지 / 마이페이지 진입 시 서버와의 통신 이전에 데이터스토어에 저장된 정보 출력 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
approved these changes
Sep 9, 2023
| @@ -84,6 +86,14 @@ class MyPageFragment : BindingFragment<FragmentMyPageBinding>(R.layout.fragment_ | |||
| mainViewModel.getUser() | |||
| } | |||
|
|
|||
| private fun initUserData() { | |||
| val data = runBlocking { dataStoreRepository.getUserInfo().first() } | |||
There was a problem hiding this comment.
getUserInfo() 함수가 suspend 함수여서 코루틴 스코프를 만들어주기 위해 runBlocking을 사용한 거 같은데
viewLifeCycleScope.launch 이용해서도 프래그먼트 뷰의 라이프사이클을 따라가는 코루틴 스코프를 만들 수 있을 거 같아요!
DataStore는 코루틴과 Flow를 사용해 데이터 검색 및 저장을 위한 완전 비동기식 API를 제공하여 UI 쓰레드를 차단할 위협을 줄여준다는 게 큰 장점이기 때문에, runBlocking은 저번에 interceptor에서처럼 동기 처리가 반드시 필요한 상황에서만 사용하는 게 좋을 거 같습니다 :)
| initTargetModifyButtonClickListener(data) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
서버 통신으로 데이터 가져오는데 걸리는 로딩 시간 때문에, 매번 캐릭터 이미지가 깜박거리는 게 신경쓰였는데 넘 좋네용!! 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers
다행히 간단하게 처리가 가능했습니다 !