[feat] 위니 업로드 / 과소비 플로우 추가 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
changed the title
sxunea
approved these changes
Feb 4, 2024
|
|
||
| private val feedType by lazy { | ||
| intent.extras?.getCompatibleSerializable(WineyFeedFragment.KEY_FEED_TYPE) | ||
| ?: WineyFeedType.SAVE |
There was a problem hiding this comment.
nullable 타입에 대한 처리가 애매해서 디폴트 값으로 SAVE를 지정했습니다!
| private val amountString by lazy { intent.extras?.getString(KEY_SAVE_AMOUNT, "") } | ||
| private val amount by lazy { intent.extras?.getString(KEY_SAVE_AMOUNT, "") } |
Comment on lines
+55
to
+70
| @BindingAdapter("switchUploadImageTitle") | ||
| fun TextView.switchUploadImageTitle(feedType: WineyFeedType) { | ||
| text = when (feedType) { | ||
| WineyFeedType.SAVE -> context.getString(R.string.upload_photo_title, "절약을 실천한") | ||
| WineyFeedType.CONSUME -> context.getString(R.string.upload_photo_title, "과소비한") | ||
| } | ||
| } | ||
|
|
||
| @BindingAdapter("switchUploadImageButtonText") | ||
| fun TextView.switchUploadImageButtonText(feedType: WineyFeedType) { | ||
| text = when (feedType) { | ||
| WineyFeedType.SAVE -> context.getString(R.string.upload_plus_text, "절약을") | ||
| WineyFeedType.CONSUME -> context.getString(R.string.upload_plus_text, "과소비를") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
타입에 따라 바뀌는 6가지 요소를 data class로 묶으면 하나의 bindingAdapter로 관리할 수는 있을 것 같아요 ~! 다만 그러면 뷰의 id에 따라 바인딩 해줘야 해서 ... 결과적으로는 지금 방향이 더 낫지 않을까 생각합니다
There was a problem hiding this comment.
오.. 어떤 방식인지 더 구체적으로 알 수 있을까요?! 뷰의 id에 따라 바인딩 한다는 게 어떤 건지 감이 잘 안 와서요!
There was a problem hiding this comment.
data class ViewTexts(
val title: String,
val description: ~~~
)
이렇게 만들고
when (id) {
R.id.uploadImageTitle -> text = viewTexts.title
}
이런 바인딩 어댑터 만들면 관리는 가능할 것 같은데, 위에 적은 것처럼 아이디를 직접참조하는 방식은 변동+증가에 따라 일일이 반영해줘야해서 결국 기존 방식이 좋을 것 같다는 말이었습니다 😄
There was a problem hiding this comment.
아하 그러네요 id가 바뀌면 일일이 다 바꿔줘야 하니까 번거롭겠네요! 그럼 우선은 지금 방식대로 머지할게요!
…o feature/feat-overcomsumption-upload # Conflicts: # app/src/main/java/org/go/sopt/winey/presentation/main/MainActivity.kt # app/src/main/java/org/go/sopt/winey/presentation/main/feed/upload/AmountFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers