[feat] 마이페이지 / 설정 #252
Merged
[feat] 마이페이지 / 설정 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-setting # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/go/sopt/winey/presentation/main/mypage/MyPageFragment.kt
|
…e-setting # Conflicts: # app/src/main/AndroidManifest.xml
|
로그아웃, 탈퇴, 알림 설정 관련 이슈 해결된 거 확인했습니다! 한가지 첨언하고 싶은 것은 마이페이지 프래그먼트의 ScrollView에 overScrollMode="never" 설정해주면 좋을 거 같습니다! 처음과 끝 부분에서도 스크롤이 되어서 캐릭터 이미지 위에 흰색 여백이 보이는 문제가 있어서요..! 영상 참고해주세요 🙂 KakaoTalk_Video_2024-02-27-16-50-07.mp4KakaoTalk_Video_2024-02-27-16-50-14.mp4 |
leeeha
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers
제 기기가 Tiramisu 이전 버전이라
ContextCompat.checkSelfPermission없이 자동 권한이 주어집니다. 그러다 보니 알림 설정 쪽 구현이 제대로 되어있는지 완전한 확인이 안되는 것 같은데 권한 설정 관련해서 올바른지 한번 실행해서 확인 부탁드립니다 !