Converts the teeth amount of a gear to the pitch diameter. #72
Conversation
|
Can we add units to all of the methods please? |
There was a problem hiding this comment.
We need to consistently name these functions. I propose renaming the functions to follow the format pitchDiameterFromMechanismName since that seems intuitive
For example:
pitchDiameterFrom3mmPulley or pitchDiameterFrom25ChainSprocket
| package coppercore.math; | ||
|
|
||
| public class GearConversionFunctions { | ||
| public static double pitchPulley3mm(int teeth) { |
There was a problem hiding this comment.
Per #52 all these functions should return a Distance, which is a unit from wpilib. So that needs to be added to all functions.
Also you'll need to include the following in your build.gradle in the dependencies block
def wpilibVersion = "2025.1.1-beta-1"
implementation "edu.wpi.first.wpiunits:wpiunits-java:$wpilibVersion"
There was a problem hiding this comment.
Comparing floating point numbers with equality is generally considered bad practice. assertEquals should have an option to specify an epsilon, and I recommend setting that to 1e-10.
There was a problem hiding this comment.
To use it just provide a third parameter which it the delta
No description provided.