Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust auto speeds #51

Closed
wants to merge 71 commits into from
Closed

Adjust auto speeds #51

wants to merge 71 commits into from

Conversation

linglejack06
Copy link
Contributor

  • refactor applyGoalSpeeds to work for teleop and auto
  • change auto speeds command to setGoalSpeeds (previously a custom auto request)
  • now auto and teleop always run through apply goal speeds

…eed methods and commands to be able to drive robot
linglejack06 and others added 22 commits October 14, 2024 08:19
@linglejack06 linglejack06 requested a review from jkleiber October 18, 2024 19:02
@linglejack06 linglejack06 self-assigned this Oct 18, 2024
@linglejack06
Copy link
Contributor Author

@jkleiber this is my attempt at adjusting to combine the applyGoalSpeeds. This should definitely not get merged until i get a chance to test with auto at shop (as my sim isn't showing a pose for whatever reason). but all it does is change auto to also always use applygoalspeeds (previously auto had a specific auto request which bypassed my applyGoalSpeeds method unless commanded to align.

@aidnem
Copy link
Contributor

aidnem commented Oct 20, 2024

@linglejack06 We rewrote a lot of drive logic yesterday in an attempt to make auto-align and autos work better (with the robot-centric controls from path planner), so this may have been rendered obsolete. We can check in on this at shop tomorrow.

@linglejack06
Copy link
Contributor Author

linglejack06 commented Oct 20, 2024 via email

@jkleiber
Copy link
Member

@linglejack06 since path planner does everything in robot relative mode, we simplified the logic by going back to what we did last season with the alignment controller running on the roboRIO rather than using the Phoenix6 FieldCentricFacingAngle request type. I don't think we found a lot of success with this, though we didn't have much time to adjust things by the time we made that change.

Personally I think we should close this PR and re-baseline off of the blue ridge brawl changes on Monday.

@jkleiber jkleiber closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants