Seamless amp #63
Merged
Seamless amp #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aidnem
commented
Oct 22, 2024
aidnem
commented
- Tune amp setpoint so that aimping is consistent
- Make aimer hold at amp position after note is ejected into amp so that the arm doesn't break itself on the amp wall by trying to come down before it is a safe distance away.
Closed
3 tasks
jkleiber
reviewed
Oct 23, 2024
src/main/java/frc/robot/subsystems/scoring/ScoringSubsystem.java
Outdated
Show resolved
Hide resolved
|
Approved for testing on the robot, will approve the actual PR once testing is complete |
aidnem
force-pushed
the
57-seamless-amp
branch
from
fe356f1 to
cc6a6ee
Compare
jkleiber
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.