Adds Onshape model to Advantagekit #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch to actually check if all of the pieces are in the right place, so i'll do that at shop
|
@minhnguyenbhs could you include a screenshot as evidence? |
|
sorry this looks horrid but I found out that the previous push still had a version of A-bot; this has B-bot on it now! it does require files to be downloaded
|
aidnem
previously approved these changes
Nov 12, 2024
|
hi! thanks for reviewing the pull request but i'm hoping to make the file so that individual components can move (i'm not entirely sure if that works yet) and making sure that the robot stops crashing advantagekit thanks! |
|
Sounds good. Request again whenever you're ready and I can review :) |
aidnem
force-pushed
the
advantagekit-cad
branch
from
09d570b to
bdef243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this looks like B-bot; my computer is a bit too slow for me to see details, but I think everything looks mostly in place except for possibly the intake?