Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic swerve #8

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Basic swerve #8

merged 5 commits into from
Aug 27, 2024

Conversation

linglejack06
Copy link
Contributor

  • add PhoenixDriveConstants file to handle configuration
  • add basic Phoenix Drive Subsystem: no alignment, auto, or special Commands

Resolves Issue #2

@linglejack06 linglejack06 self-assigned this Aug 26, 2024
Copy link
Member

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments - also does this work in sim?

src/main/java/frc/robot/BuildConstants.java Outdated Show resolved Hide resolved
@linglejack06
Copy link
Contributor Author

@jkleiber this request has no sim. However, I already have the sim on another branch built. Haven't tested yet though. I figured I would push that basic stuff to main then get the sim and auto done under separate pull request

@linglejack06
Copy link
Contributor Author

@jkleiber will mentioned something about this pull request but he couldn't remember what it was. He had said you asked me to do something so we could get it merged? Is it just the comments?

@jkleiber
Copy link
Member

@linglejack06 can we just gitignore and untrack the autogenerated constants file (then this will be good to merge imo)

@linglejack06
Copy link
Contributor Author

@jkleiber it should be fixed now

@linglejack06 linglejack06 merged commit f14be0f into main Aug 27, 2024
3 checks passed
@linglejack06 linglejack06 deleted the basic-swerve branch August 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants