Adding procfile_structure on app api #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/app
route should expose the procfile_structure of the app release. Since the structure on the/app
route is not indicative of the actual deployable processes of the application, there should be another json structure that can tell us what the procfile is actually set to for the latest release. When usingprocfile_structure
we can tell which of the processes exist in our procfile at this particular release:The idea is that we can use
procfile_structure
for scaling and validating which processes we can actually scale through the/scale
route. This is so because a call to.../app/{app_name}/scale
with a payload{"worker": 1}
would actually fail with404 Not Found
and this return from the api:Our app structure is below:
But a call for each of the processes in procfile_structure would not fail the scale call.
This has been tested extensively with git remote application deployments and Docker image pull deployments.
The tests are not written yet.
Code in deis-cli has not been written yet.