Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(minio): upgrading to the latest release #7

Merged
merged 1 commit into from
Feb 13, 2019
Merged

chore(minio): upgrading to the latest release #7

merged 1 commit into from
Feb 13, 2019

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Feb 11, 2019 •
edited
Loading

For #6

@kingdonb kingdonb mentioned this pull request Feb 11, 2019
Open
@Cryptophobia
Copy link
Member

Alright, I will merge this in right after you let me know how the test went. 👍

@Cryptophobia Cryptophobia self-requested a review February 11, 2019 22:54
Cryptophobia
Cryptophobia approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kingdonb
Copy link
Member Author

This is tested and works OK. I did not deal with the migration stuff, there may not even be any need.

I'll look into it, but this should be OK to merge as-is. It's at kingdonb/minio:canary, I put it in my deployment and terminated the old pod... logged into the database, created the bucket again, ran do_backup

Then verified with envdir "$WALE_ENVDIR" wal-e --terse backup-list that the backup made it.

LGTM2

@Cryptophobia
Copy link
Member

Alright sounds good! We will test again before next patch release.

Cryptophobia
Cryptophobia approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cryptophobia Cryptophobia merged commit 7d1876d into teamhephy:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryptophobia Cryptophobia Cryptophobia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingdonb @Cryptophobia