Use paste.deploy to parse alembic config files #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alembic uses configparser to parse its config files, which is compatible with the paste.deploy ini config files in terms of encoding, but paste.deploy has additional features such as `user = config:` lines. This reduces the amount of places that alembic config files are generated throughout the codebase and uses paste.deploy to extract the config values for the `app:conduit` section before directly inserting them into an alembic config. This allows users to omit `script_location` from test.ini, and moreover to omit any parameters required by alembic that are set in a parent of the relevant app:conduit block.
MatthewWilkes
force-pushed
the
wilkes/alembic-script-location
branch
from
e8cd265 to
60ccad9
Compare
|
Force-push was following a rebase onto master. |
|
Let's hold off on this, one of the other TODOs is related. |
|
I've created teamniteo/pyramid_deferred_sqla#3 to track the related topic. I think it would be nice if we could unify these two concepts, so the |
|
Instead of using Pyramid itself also uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alembic uses configparser to parse its config files, which is
compatible with the paste.deploy ini config files in terms of
encoding, but paste.deploy has additional features such as
user = config:lines. This reduces the amount of places thatalembic config files are generated throughout the codebase and
uses paste.deploy to extract the config values for the
app:conduitsection before directly inserting them into an alembic config.
This allows users to omit
script_locationfrom test.ini, and moreoverto omit any parameters required by alembic that are set in a parent
of the relevant app:conduit block.