Checksum : use md5 instead of crc32 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me. Can you please add some comments around the change you've made? |
|
The goal of the exercice was to replacing the hash method. Famous hash methods are md5 and sha1, and sha1 seems to be described as "more stronger", but I prefered test md5 (for the unpopular side and maybe it has things in common with sha1). After verification in the terminal it seems to work fine… |
|
Sorry, as explained in class, I just want you to modify your Pull Request to see how it's done, so, the goal is to add the comment inside your script, to update the Pull Request. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An other function for hashing: md5 !