Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Search): Add text and categories search #190

Merged
merged 41 commits into from
Aug 15, 2023
Merged

feat(Search): Add text and categories search #190

merged 41 commits into from
Aug 15, 2023

Conversation

vogelino
Copy link
Contributor

@vogelino vogelino commented Aug 8, 2023 •
edited
Loading

This PR adds a text and category search into the sidebar and URL.
It should now be possible to:

  • Filter items by text
  • Filter items by category
  • Combine filters together to find specific items
  • Get the same results when reloading the page and using the browser history
  • Clear the text search easily
  • See the first two categories by default when no parameters exist in the URL
  • Cache the result once loaded so it isn't requested from the API a second time
  • Avoid changing the filters while a request to the API is happening
  • Avoid text searches longer than 100 chars long (This limit can be changed)
  • Show the Sidebar button only when opened (Now only says "Suche" and doesn't show the number of active filters, as the categories are always active by default)

New texts key added in Grist:

  • textSearchLabel
  • textSearchPlaceholder
  • textSearchCategorySelfHelp
  • textSearchCategoryAdvising
  • textSearchCategoryClinics
  • textSearchCategoryOnlineOffers
  • textSearchCategoryDisctrictOfficeHelp
  • optionalFurtherSearchIntroText
  • filtersButtonLoading

Changed texts key in Grist:

  • filtersSearchTargetLabel
  • filterLabel

Todos:

  • URL Params Parsing
  • API search
  • Button count update
  • Refactor complex functions
  • Show current search config in list
  • Show "No results UI" in list
  • Advanced Text Field UI with confirmed state
  • Limit and sanitize text seach query

@vogelino
fix(history): Fall back to home in bo back button when no history
6123ad7
@vogelino
Merge branch 'staging' into refactor/better-back-button
5159f4f
@vogelino
Merge branch 'staging' into refactor/better-back-button
b5b78dd
@vogelino
fix(Links): Encode the back url into the query params to avoid loss o…
5bfaebf 
…f filters
@vogelino
chore(Button): Fix types of query in Button
170eaca
@vogelino
refactor(Map): Scroll to previously clicked facility on back button c…
d666aa4 
…lick
@vogelino
refactor(map): Cast ScrollBehavior type because typesrcipt does under…
621b267 
…stand it
@vogelino
Merge branch 'staging' into fix/avoid-filters-reset
de6c8a6
@vogelino
fix(UrlStateContext): Use router push with shallow statt window replace
b7391cc
@vogelino
Merge branch 'fix/local-missing-map-markers' into fix/avoid-filters-r…
e3b3c46 
…eset
@vogelino
feat(TextSearch): Add Text Search UI
3e7ce23
@vogelino
feat(useActiveIdsBySearchTerm): Filter data by text or category
20e4ed0
@vogelino
feat(ActiveFiltersList): Show the text search and categories in the l…
f291cb6 
…ist view
@vercel
Copy link

vercel bot commented Aug 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wegweiser-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 7:35am

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tailwindcss/container-queries 0.1.1 None +0 8.46 kB malfaitrobin
swr 2.2.0 None +1 301 kB vercel-release-bot

@vogelino
refactor(useActiveIdsBySearchTerm): Show all items for first two cate…
c17aa3b 
…gories by default

And remove logic that reactivates all categories when none is selected
anymore as discussed with @Esshahn
@vogelino vogelino marked this pull request as ready for review August 9, 2023 15:37
@vogelino vogelino requested a review from dnsos as a code owner August 9, 2023 15:37
dnsos
dnsos reviewed Aug 10, 2023
View reviewed changes
pages/sofortige-hilfe.tsx Outdated Show resolved Hide resolved
@vogelino
fix(facilityFilterUtil): Remove encodeURIComponent
e14a4fd 
as it leads to formatting problems and is already handled by next
@vogelino vogelino force-pushed the feat/full-text-search-frontend branch from ecee89b to e14a4fd Compare August 11, 2023 07:10
raphael-arce
raphael-arce requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: a few typos to correct, otherwise LGTM!

src/lib/UrlStateContext.tsx Outdated Show resolved Hide resolved
src/lib/UrlStateContext.tsx Outdated Show resolved Hide resolved
src/lib/facilityFilterUtil.ts Outdated Show resolved Hide resolved
src/lib/hooks/useFilteredFacilitiesCount.ts Outdated Show resolved Hide resolved
raphael-arce
raphael-arce requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, minor typos other LGTM

src/lib/UrlStateContext.tsx Outdated Show resolved Hide resolved
src/lib/TextsContext.tsx Outdated Show resolved Hide resolved
@vogelino vogelino merged commit 2a169bf into staging Aug 15, 2023
5 checks passed
@vogelino vogelino deleted the feat/full-text-search-frontend branch August 15, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsos dnsos dnsos left review comments

@raphael-arce raphael-arce raphael-arce requested changes

@ff6347 ff6347 Awaiting requested review from ff6347

@Esshahn Esshahn Awaiting requested review from Esshahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vogelino @raphael-arce @dnsos