Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(revalidation): Remove nextjs revalidation #193

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

vogelino
Copy link
Contributor

@vogelino vogelino commented Aug 14, 2023

This PR removes next.js revalidation on all pages. The reason is that when the GRIST Database contains formatting errors in some rows, the revalidation might fail and this can result in the overview being out of sync with individual facility pages. And because revalidation serves the previous version of a page, it fails silently and this is a problem.

We chose to use a webhook to deploy the website completely, which would completely fail with formatting errors and therefore would be noticed.


@vogelino vogelino requested a review from dnsos as a code owner August 14, 2023 08:34
@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
wegweiser-frontend ✅ Ready (Inspect) Visit Preview Aug 14, 2023 8:34am

Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vogelino vogelino merged commit 44f7af2 into staging Aug 15, 2023
5 checks passed
@vogelino vogelino deleted the refactor/remove-revalidation branch August 15, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants