Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency cmdk to v1 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): update dependency cmdk to v1 #14

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 15, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cmdk (source) ^0.2.0 -> ^1.0.0 age adoption passing confidence

Release Notes

pacocoursey/cmdk (cmdk)

v1.0.4

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.3...v1.0.4

v1.0.3

Compare Source

  • Fix use-sync-external-store shim for compatibility with Next.js 15 and React 19 RC

v1.0.2

Compare Source

  • Remove use-sync-external-store shim to support Next.js 15 and React 19 RC

Full Changelog: pacocoursey/cmdk@v1.0.1...v1.0.2

v1.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.0...v1.0.1

v1.0.0

Compare Source

This is a major version release as it contains breaking changes.

Breaking Changes

You will need to update your code to account for these changes before upgrading to [email protected].

value is now case sensitive 3dae25d

The value prop you pass to Command.Item and receive in onSelect is now case sensitive. But while the value is no longer lowercased, it is still trimmed.

Command.List is now required (CommandList in shadcn) 54aa261

Rendering the Command.List part (CommandList if using shadcn) is now mandatory. Otherwise, you should expect to see an error like this:

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

The fix:

// Before
<Command label="Command Menu">
	<Command.Input />
	<Command.Item />
	{/* ... */}
</Command>
// After
<Command label="Command Menu">
	<Command.Input />

	<Command.List>
		<Command.Item />
		{/* ... */}
	</Command.List>
</Command>
Update [aria-disabled] and [aria-selected] CSS selectors c57e6b7

The aria-disabled and aria-selected props will now be set to false, instead of being undefined. If you previously used CSS selectors based on attribute presence, you will now need to use the attribute value.

/* Before */
[aria-disabled] {}
:not([aria-disabled]) {}

/* After */
[aria-disabled="true"] {}
[aria-disabled="false"] {}

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v0.2.1...v1.0.0

Configuration

📅 Schedule: Branch creation - "every 2 weeks on Monday before 7am" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from tsboter and hanshack as code owners July 15, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsboter tsboter Awaiting requested review from tsboter tsboter is a code owner

@hanshack hanshack Awaiting requested review from hanshack hanshack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants