Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Windows PowerShell 5.1 compatibility #94

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Enhancement - Windows PowerShell 5.1 compatibility #94

merged 1 commit into from
Sep 8, 2024

Conversation

SamErde
Copy link
Contributor

@SamErde SamErde commented Aug 21, 2024

Pull Request

Description

Enhanced actions_bootstrap.ps1 to support Windows PowerShell 5.1 while installing Pester on Windows. It currently checks for $IsWindows, which was only introduced in PowerShell 6.

I updated it to -and ($IsWindows -or $PSVersionTable.PSVersion -ge [version]'5.1') but if minimal code is desired, it could be further simplified to -and $PSVersionTable.PSVersion -ge [version]'5.1').

License

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

…ap.ps1

Enhanced Windows check while installing Pester to support Windows PowerShell 5.1. It currently checks for $IsWindows, which was only introduced in PowerShell 6.

I updated it to `-and ($IsWindows -or $PSVersionTable.PSVersion -ge [version]'5.1')` but if minimal code is desired, it could be simplified to `-and $PSVersionTable.PSVersion -ge [version]'5.1')`.
@techthoughts2 techthoughts2 self-assigned this Aug 22, 2024
@techthoughts2 techthoughts2 merged commit ab5837a into techthoughts2:Enhancements Sep 8, 2024
5 checks passed
@SamErde SamErde deleted the Enhancements branch September 8, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants