-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hyprland #85
Conversation
Everything works except actually pasting the contents, although that's unrelated to this PR. The content is successfully copied to the clipboard. I also tried using |
Hmm, I'm onboard with implementing specific support for Gnome, KDE, and probably wlroots directly in Perhaps as a first step, I could try making the app-info function used a variable, and changing the window |
Hyprland is wlroots-based, I don't know of any way to implement this generically for all wlroots compositors. For sway you'll need to use sway-specific tooling as well as far as I know. Hyprland is the most popular wlroots compositor. |
Mmm, while it may not currently be possible to implement a wlroots-generic method, I don't think that supporting the entire set of wayland compositors is a sensible goal (also, I was under the impression that Sway remains more common that Hyprland). What we can do though is have say a wiki page for less common ones though, and link to it in the docstring. |
Yeah, I might have been a bit overzealous claiming that Hyprland is the most popular wlroots-based compositor 😬. It's hard to measure, but I think it's fair to say that it's as popular as sway, or at least that it's definitely not a niche compositor as far as wlroots-based compositors go. I understand your reluctance regarding adding support for a bunch of different compositors though. I rebased the PR over your latest changes in master. Feel free to close the PR though. |
I think I'll close this PR for now, but let's not waste your work! I'll start a wiki page on adding support for less-common wayland compositors, and you can paste your code there 🙂 |
Here's a wiki page for this: https://github.com/tecosaur/emacs-everywhere/wiki/Custom-app-info-functions-for-less-common-compositors |
(the wiki page should be publically editable) |
Thanks, I added instructions for Hyprland there. |
There is https://wayland.app/protocols/wlr-foreign-toplevel-management-unstable-v1 supported by (most?) wlroots compositors as well as hyprland. (note that the protocol also supports window activation, though those clients don't support it) edit 2: just found https://git.sr.ht/~brocellous/wlrctl, which supports all the input-side stuff like activation and typing. A wlrctl + waylevel impl seems viable. |
#50